fix: correctly revert task status on network error in toggleTaskStatus#699
Open
akhilmodi29 wants to merge 1 commit into
Open
fix: correctly revert task status on network error in toggleTaskStatus#699akhilmodi29 wants to merge 1 commit into
akhilmodi29 wants to merge 1 commit into
Conversation
Author
|
@Charushi06 Please review this PR and add the required labels including gssoc:approved. This fixes the wrong revert logic in toggleTaskStatus on network error. Labels suggested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #698
Problem
In store.js toggleTaskStatus(), the catch block had wrong
revert logic:
task.status = newStatus === 'Done' ? 'Not Started' : 'Done';
This sets the status to the NEW status instead of the
ORIGINAL status on network failure. So if the API call
fails, the task status is not correctly reverted back
to what it was before the toggle.
Fix
Store the original status before toggling:
const originalStatus = task.status;
Then revert to it on network error:
task.status = originalStatus;
Testing